Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

/* */ Comments in source Sass files are not closed correctly #900

Closed
liamprescott opened this issue Apr 28, 2015 · 5 comments
Closed

/* */ Comments in source Sass files are not closed correctly #900

liamprescott opened this issue Apr 28, 2015 · 5 comments

Comments

@liamprescott
Copy link

/* */ Comment statements in source Sass files are not closed correctly in the output CSS when output-style is either 'compact' or 'compressed'

OS: Windows

CLI:

node-sass style/scss/main.scss style/css/main.css --source-map true --output-style compact

The following Sass:

/**
 * Comment
 */
.foo
{
  display:block;
} 

Outputs the following CSS:

/** This is global comment before a class statement /
.foo { display: block; }

/*# sourceMappingURL=main.css.map */

Please note the missing * before the closing / of the comment in the CSS.

@liamprescott
Copy link
Author

Apologies. Output CSS should read:

/** Comment /
.foo { display: block; }

/*# sourceMappingURL=main.css.map */

@xzyfer
Copy link
Contributor

xzyfer commented Apr 28, 2015

This has been fixed in Libsass 3.2.0 (sass/libsass#1137) and will be node-sass@3.0.0

@xzyfer xzyfer added this to the 3.0 milestone Apr 28, 2015
@liamprescott
Copy link
Author

Brilliant - any idea when node-sass@3.0.0 will be available?

@xzyfer
Copy link
Contributor

xzyfer commented Apr 28, 2015

Ideally this week. There are some outstanding PRs and issues that need to be resolved first.

@xzyfer xzyfer mentioned this issue May 5, 2015
19 tasks
@xzyfer
Copy link
Contributor

xzyfer commented May 6, 2015

Fixed in 3.0.0.

@xzyfer xzyfer closed this as completed May 6, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants