Additional tests for SassTypes::Color

[saper]

A byproduct of #1054

[xzyfer]

Ship when ready! 🎉

[saper]

Ship when ready! 🎉

Not sure I like the indented layout of output. Opinions? We need moar of these! List! Maps! Crazy constructors! If I do conversion in the binding code, "new sass.types.Boolean('string')" brings false, if I do casting - it errors. I think the latter is better?

[xzyfer]

Not sure I like the indented layout of output. Opinions?

I don't have my dev laptop with me atm.

However generally speaking I care about the layout of the test themselves with regards to readability (which I think is perfectly fine). IMHO the output doesn't matter since you only care about the tests that fail :)

[xzyfer]

If I do conversion in the binding code,
"new sass.types.Boolean('string')" brings false,
if I do casting - it errors. I think the latter is better?

I'm not following. Does this relate directly to this PR. I'd rather we didn't change the implementation of the Sass types atm.

[saper]

If I do conversion in the binding code,
"new sass.types.Boolean('string')" brings false,
if I do casting - it errors. I think the latter is better?

I'm not following. Does this relate directly to this PR. I'd rather we didn't change the implementation of the Sass types atm.

Good, I'll keep that in mind! Once I figure out how it works :>