This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Bump LibSass to 3.3.2 #1248
Merged
Bump LibSass to 3.3.2 #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saper looks like there may have been some breaking changes to path handling in custom importer. Could you please take a look, I'm about to jump on plane. |
|
Will check, probably abs/rel story. |
This was referenced Nov 11, 2015
Closed
|
It's working \o/ |
|
\o/ |
|
Argh looks like we've made AppVeyor upset :( |
|
and it works for libsass ....? |
|
Correct. My guess we not importing sass.h somewhere we were previously importing it. Maybe sass/libsass@3.3.1...master#diff-d05ceec51aad0a31ac61c72b95ed35e1L20 |
|
Argh it's too late for this. I need sleep. |
|
Bisected the offending commit to sass/libsass@827eac5 |
|
Ok, figured it out. In sass/libsass@827eac5 the This is required to compile LibSass on VS < 2015. LibSass AppVeyor uses VS 2015 we use VS 2013. |
xzyfer
force-pushed
the
trash/v3.4.2
branch
2 times, most recently
from
ec62d9b
to
c147497
Compare
This is a work around for sass/libsass#1719 which removed a header that broke compilation on VS 2013.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.