-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Better error messages for missing binaries #1428
Conversation
We should keep the path we were looking at as well. I'll add that back in. |
e7e3892
to
05bb8e4
Compare
I like it a lot. |
Good question. Maybe @am11 has some background?
|
05bb8e4
to
5ac5bdb
Compare
Updated the error messages to include the expected binary path when it's missing. I'll add some tests and 🚢 |
b241308
to
e27041d
Compare
ef72c2e
to
c41cb20
Compare
This is another iteration on improving the infamous >The `libsass` binding was not found Messages will now provide more useful information which will - give users a chance to resolve the problem themselves - give us more debug information from the error message alone Error messages produce now will look like: >Node Sass does not yet support your current environment: OS X 64-bit with Node.js 4.x >For more information on which environments are supported please see: >http://.... >Node Sass could not find a binding for your current environment: OS X 64-bit with Node.js 4.x >Found bindings for the following environments: > - OS X 64-bit with io.js 3.x > - OS X 64-bit with Node.js 5.x >This usually happens because your environment has changed since running `npm install`. >Run `npm rebuild node-sass` to build the binding for your current environment. >Node Sass could not find a binding for your current environment: OS X 64-bit with Node.js 4.x >This usually happens because your environment has changed since running `npm install`. >Run `npm rebuild node-sass` to build the binding for your current environment.
c41cb20
to
cf87e0b
Compare
@saper as suspected there is a reason for the having the directories - #712 (comment) |
This is another iteration on improving the infamous
Messages will now provide more useful information which will
Error messages produced now be one of the following flavours:
It's worth noting that we can't really do much better than the following if users are using custom binary names or paths. I'm ok with this since those users almost never file issues.
/cc @saper