Python 3 support by bumping node-gyp to 6.1.0 #2936
Conversation
|
Downgrading to |
ext
changed the title
|
I guess that would make a transition easier, I've updated to PR to use node-gyp@6.1.0 instead. |
|
I would like to add a |
|
@adamretter Please view the Files changed and then click the Positive reviews give project maintainers confidence that these changes are in the best interests of the project. |
|
+1 for this. please include in the next merge |
|
@surfaceowl Please view the Files changed and then click the Positive reviews give project maintainers confidence that these changes are in the best interests of the project. |
|
Any reason this hasn't been merged? |
|
@keithslater Please do the following #2936 (comment) |
It seems like the maintainers are moving towards deprecating node-sass and libsass in favor of dart-sass, see #2952. |
BREAKING CHANGE: requires at least node 6
I know similar pull requests have been declined before because it breaks compatibility.
However the current v4 uses node-gyp@3.8.0 which does not support python 3. Python 2 is now end of life since 1 jan 2020 and major distrubutions are starting to drop it (debian, fedora, ubuntu etc). Python 3 support landed in node-gyp@5.0.4.
This is a problem because node-sass will no longer work for new installations where the precompiled binary cannot be used (enterprise firewalls anyone?). So for this user group (myself included) node-sass is effectively unusable right now.
I've already seen that v5 solves this issue but I don't see a timeline and it doesn't seem to be actively worked on. So my suggestion is to either declare this project dead and force users to use a replacement such as dart-sass or merge this or a similar fix.
Since node-gyp@7.0.0 requires node 10 the minimal node version is bumped here as well. This makes sense since node 10 is the current oldest supported version.
EDIT: downgraded to 6.1.0 to support/require node 6 instead of 10.