This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
sourceMaps non-string option while sourceComments='map' causes crash #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for picking this @rvagg, I've been away travelling and haven't had much time to check it out. Will try to get a release out next week. |
andrew
pushed a commit
that referenced
this pull request
Jul 25, 2014
sourceMaps non-string option while sourceComments='map' causes crash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fixes #337, the bug is caused by the grunt-sass library setting
sourceCommentstomapwhile leavingsourceMapsasundefined. The way I chose to fix this was to setsourceMapsto''as that seems to be an acceptable way to pass this option to libsass (tbh I don't know what it ends up doing with it but I can confirm it works and I think the tests might also be doing this).Also, I changed the binary loader section and removed the obj.target directory as the buillds end up being linked into the directory above that and it should be the proper place to load it from. I also added the Debug directory as that's where they end upwith
--debugand I needed that to get some lldb line number magic out of this crash.