This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Build: Uses different strategy to test bins status #491
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only 90% of the test should pass.
|
That should alleviate some of the pain for now 👍 |
| reporter: function (stats) { | ||
| total = stats.total; | ||
| failures = stats.failures; | ||
| }, |
There was a problem hiding this comment.
Indentation is a little weird here ;Pp.
There was a problem hiding this comment.
We should add JSCS in our tests. :D
What do you propose here?
There was a problem hiding this comment.
Rather than have more linting in the test suite, we need something like https://codeclimate.com/ or http://houndci.com to encourage following the styleguide.
|
I think we should republish the npm before getting plethora of complains. 💬 |
|
Yup. |
andrew
added a commit
that referenced
this pull request
Oct 29, 2014
Build: Uses different strategy to test bins status
|
Tagging a new release now, will be 1.1.1. |
|
Awesome! 👍 |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Show currentDir when outputting not found error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 90% of the test should pass.
Related: #487 (comment) and #490.
/cc @andrew, @nschonni, @keithamus, @kevva