Misc. improvements #717

am11 · 2015-02-27T14:46:10Z

Removes tests from publishing. consider adding tests directory to npmignore due to windows 260 character path limitation #683
- Uses new strategy to validate binary after
  the download.
- Moves mocha under dev-dependencies in
  package.json.

Truncates the forth portion from v8 version
as discussed in Time to ship 3.0.0? #710.

Moves pangyp from dev to main dependencies in
package.json.

CLI: Overrides default version info.
- Based on Configurable version option sindresorhus/meow#2.
- Adds alias -v.
- Improves info text; inspired by Less CLI. :)
- Updates readme.

The new version text looks like:

$ node-sass -v

node-sass 2.0.1 (Wrapper) [JavaScript]
libsass 3.1.0 (Sass Compiler) [C/C++]

@lukeapage, hope you don't mind! ©️ 😉

Repo: Updates CONTRIBUTING.md.
- Adds instructions.
- Removes obsolete info.

This is for DRY'ing comments on repeating issues.

CI: Updates and formats configuration files.

* Remove tests from publishing. sass#683 * Uses new strategy to validate binary after the download. * Moves mocha under dev-dependencies in package.json. * Truncates the forth potion from v8 version as discussed in sass#710. * Moves pangyp from dev to main dependencies in package.json. Issue URLs: sass#683 and sass#710. PR URL: sass#717.

* Removes tests from publishing. sass#683 * Uses new strategy to validate binary after the download. * Moves mocha under dev-dependencies in package.json. * Truncates the forth portion from v8 version as discussed in sass#710. * Moves pangyp from dev to main dependencies in package.json. Issue URLs: sass#683 and sass#710. PR URL: sass#717.

am11 · 2015-02-27T23:07:47Z

@andreitognolo, does SnapCI actually build and run the tests? It never fails (even when we have something broken) and reports back success in about five seconds! Are we missing something here?

am11 · 2015-02-27T23:17:25Z

.npmignore

+lib-cov
+node_modules
+vendor
+test


This is .gitignore union test, because npm docs suggest: in absence of .npmignore, it takes .gitignore into account and when .npmignore is present, it essentially overrides .gitignore.

* Based on sindresorhus/meow#2. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

xzyfer · 2015-02-28T02:13:41Z

lib/extensions.js

@@ -28,10 +30,26 @@ function getRuntimeInfo() {
 */

 function getBinaryIdentifiableName() {
+  var v8SemVersion = process.versions.v8;


All this code is essentially just

var v8SemVersion = process.versions.v8.split('.').slice(0, 2).join('.')

Shouldn't it be .slice(0, 3) to extract semver?

In some releases (for instance node v0.12.0), there are three portions (3.28.73). While in others (all iojs releases till date) have four portions.

I thought it would be good to save a join when v8 version already have three portions.

You're correct it should be (0,3)

I thought it would be good to save a join when v8 version already have three portions.

Since this is essentially a one off operation I don't see any benefit in saving a join when it comes at the cost of added verbosity.

It took me a couple reads of this this code to understand it and I already knew what it was trying to do.

Makes sense. 👍

Fixed by 9bd034c.

* Removes tests from publishing. sass#683 * Uses new strategy to validate binary after the download. * Moves mocha under dev-dependencies in package.json. * Truncates the forth portion from v8 version as discussed in sass#710. * Moves pangyp from dev to main dependencies in package.json. Issue URLs: sass#683 and sass#710. PR URL: sass#717.

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) * Updates readme. PR URL: sass#717.

* Removes tests from publishing. sass#683 * Uses new strategy to validate binary after the download. * Moves mocha under dev-dependencies in package.json. * Truncates the forth portion from v8 version as discussed in sass#710. * Moves pangyp from dev to main dependencies in package.json. Issue URLs: sass#683 and sass#710. PR URL: sass#717.

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) * Updates readme. PR URL: sass#717.

* Adds instructions. * Removes obsolete info. This is for DRY'ing comments on repeating issues.

Misc. improvements

Implement emitting utf8 charset when seen in output

am11 added Dev - WIP Feature - Implementation labels Feb 27, 2015

This was referenced Feb 27, 2015

postinstall fails with iojs-1.4.1 #715

Closed

Installation Fails on Ubuntu with tunneling socket could not be established #705

Closed

am11 force-pushed the build-fixes branch from 851f1b8 to b1bc102 Compare February 27, 2015 15:39

am11 force-pushed the build-fixes branch from b1bc102 to fb8786d Compare February 27, 2015 23:04

am11 reviewed Feb 27, 2015
View reviewed changes

am11 added a commit to am11/node-sass that referenced this pull request Feb 28, 2015

CLI: Overrides default version info.

06ae56a

* Based on sindresorhus/meow#2. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

am11 force-pushed the build-fixes branch from 06ae56a to 6e51b82 Compare February 28, 2015 00:39

am11 added a commit to am11/node-sass that referenced this pull request Feb 28, 2015

CLI: Overrides default version info.

6e51b82

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

am11 changed the title ~~Build: Misc. improvements~~ Misc. improvements Feb 28, 2015

am11 force-pushed the build-fixes branch from 8346e40 to dd0494e Compare February 28, 2015 01:58

am11 added a commit to am11/node-sass that referenced this pull request Feb 28, 2015

CLI: Overrides default version info.

9bda6e6

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

xzyfer reviewed Feb 28, 2015
View reviewed changes

am11 force-pushed the build-fixes branch from d5fa9b8 to 08f340d Compare February 28, 2015 04:03

am11 added a commit to am11/node-sass that referenced this pull request Feb 28, 2015

CLI: Overrides default version info.

004777d

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

am11 force-pushed the build-fixes branch from 08f340d to 7b43ea4 Compare February 28, 2015 04:30

am11 added a commit to am11/node-sass that referenced this pull request Feb 28, 2015

CLI: Overrides default version info.

3bef66e

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) PR URL: sass#717.

am11 force-pushed the build-fixes branch from 7b43ea4 to 28599af Compare February 28, 2015 04:35

am11 added a commit to am11/node-sass that referenced this pull request Feb 28, 2015

CLI: Overrides default version info.

039a238

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) * Updates readme. PR URL: sass#717.

am11 added 3 commits February 28, 2015 07:24

CLI: Overrides default version info.

e016d85

* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) * Updates readme. PR URL: sass#717.

Repo: Updates CONTRIBUTING.md.

cfc60b1

* Adds instructions. * Removes obsolete info. This is for DRY'ing comments on repeating issues.

am11 force-pushed the build-fixes branch from 28599af to cfc60b1 Compare February 28, 2015 05:24

am11 added the up-for-grabs label Feb 28, 2015

am11 removed the Dev - WIP label Feb 28, 2015

am11 force-pushed the build-fixes branch 4 times, most recently from 23eeed8 to 3d4042e Compare February 28, 2015 07:01

CI: Updates and formats configuration files.

74ce913

am11 force-pushed the build-fixes branch from 3d4042e to 74ce913 Compare February 28, 2015 07:10

am11 added a commit that referenced this pull request Feb 28, 2015

Merge pull request #717 from am11/build-fixes

6a10b92

Misc. improvements

am11 merged commit 6a10b92 into sass:master Feb 28, 2015

am11 deleted the build-fixes branch February 28, 2015 07:12

am11 removed the up-for-grabs label Feb 28, 2015

am11 mentioned this pull request Feb 28, 2015

consider adding tests directory to npmignore due to windows 260 character path limitation #683

Closed

mansona mentioned this pull request Mar 4, 2015

npm ERR! node-sass@2.0.1 postinstall: node scripts/build.js npm #693

Closed

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024

Merge pull request sass#717 from mgreter/feature/utf8-charset

705e6dc

Implement emitting utf8 charset when seen in output

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc. improvements #717

Misc. improvements #717

am11 commented Feb 27, 2015

am11 commented Feb 27, 2015

am11 Feb 27, 2015

xzyfer Feb 28, 2015

am11 Feb 28, 2015

xzyfer Feb 28, 2015

am11 Feb 28, 2015

Misc. improvements #717

Misc. improvements #717

Conversation

am11 commented Feb 27, 2015

am11 commented Feb 27, 2015

am11 Feb 27, 2015

Choose a reason for hiding this comment

xzyfer Feb 28, 2015

Choose a reason for hiding this comment

am11 Feb 28, 2015

Choose a reason for hiding this comment

xzyfer Feb 28, 2015

Choose a reason for hiding this comment

am11 Feb 28, 2015

Choose a reason for hiding this comment