This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Respect the LIBSASS_EXT build flag when falling back to git #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
feat/build/respect-libsass-ext-flag
branch
2 times, most recently
from
fa77044 to
81a080b
Compare
|
@saper I think this is legit given the use case for |
|
Yeah but to be fully kosher you need to take care of the command line option as well. |
|
I've had a look around and I can't a relevant cli flag. Am I missing something? |
|
On Wed, 29 Apr 2015, Michael Mifsud wrote:
I've had a look around and I can't a relevant cli flag. Am I missing something?
They are buried in
https://github.com/sass/node-sass/blob/master/scripts/build.js#L130-L131
Nice CLI option handling after 3.0.0 :)
|
|
Yeah I see that, but it looks like it's actually pulling the value out of env when building the cli flags. is that not the case? |
|
I guess it's possible if options.args = ['--libsass_ext', '/path/to/libsass'] |
xzyfer
force-pushed
the
feat/build/respect-libsass-ext-flag
branch
from
81a080b to
b19446f
Compare
|
On Wed, 29 Apr 2015, Michael Mifsud wrote:
Yeah I see that, but it looks like it's actually pulling the value out of env when building the cli flags. is that not the case?
I should have bean clearer:
If you 'node script/install.js --libsass_ext=auto', `installGitDependencies` will not notice.
We could move installGitDependencies a bit down after constructing args first.
|
xzyfer
force-pushed
the
feat/build/respect-libsass-ext-flag
branch
from
b19446f to
ff3fe62
Compare
|
Yeah cool. Updated to handle the cli flag. |
xzyfer
added a commit
that referenced
this pull request
May 3, 2015
Respect the LIBSASS_EXT build flag when falling back to git
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the build script to respect the LIBSASS_EXT build flag when falling back to git. Originally suggested in #876 (comment)
@saper does this suit your usecase?