Skip to content

Commit

Permalink
Remove the libsass TODO from a bunch of passing specs (#1693)
Browse files Browse the repository at this point in the history
* Fix the specs about comments in CSS selectors

Nesting a test directory inside another one is not supported.

* Remove the libsass TODO from a bunch of passing specs
  • Loading branch information
stof authored Sep 7, 2021
1 parent 4a5d1f0 commit 7fd8944
Show file tree
Hide file tree
Showing 13 changed files with 41 additions and 81 deletions.
7 changes: 0 additions & 7 deletions spec/core_functions/selector/extend/simple/pseudo/arg.hrx
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
<===> options.yml
---
:todo:
- sass/libsass#3068

<===>
================================================================================
<===> class/equal/input.scss
a {b: selector-extend(":c(@#$)", ":c(@#$)", "e")}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ a {

<===>
================================================================================
<===> not/is/options.yml
---
<===> not/is/list/options.yml
:todo:
- sass/libsass#3154
- sass/libsass#3154

<===> not/is/list/input.scss
a {b: selector-extend(":not(.c)", ".c", ":is(.d, .e)")}
Expand All @@ -82,6 +81,10 @@ a {

<===>
================================================================================
<===> not/is/list_of_complex/options.yml
:todo:
- sass/libsass#3154

<===> not/is/list_of_complex/input.scss
a {b: selector-extend(":not(.c)", ".c", ":is(.d .e, .f .g)")}

Expand Down Expand Up @@ -151,6 +154,8 @@ a {
:todo:
- sass/libsass#3154

<===>
================================================================================
<===> is/simple/input.scss
a {b: selector-extend(":is(.c)", ".c", ".d")}

Expand Down Expand Up @@ -201,11 +206,6 @@ a {

<===>
================================================================================
<===> matches/matches_in_extender/options.yml
---
:todo:
- sass/libsass#3069

<===> matches/matches_in_extender/input.scss
a {b: selector-extend(":matches(.c)", ".c", ":matches(.d, .e)")}

Expand Down Expand Up @@ -236,11 +236,6 @@ a {

<===>
================================================================================
<===> any/any_in_extender/options.yml
---
:todo:
- sass/libsass#3069

<===> any/any_in_extender/input.scss
a {b: selector-extend(":any(.c)", ".c", ":any(.d, .e)")}

Expand Down Expand Up @@ -271,11 +266,6 @@ a {

<===>
================================================================================
<===> current/current_in_extender/options.yml
---
:todo:
- sass/libsass#3069

<===> current/current_in_extender/input.scss
a {b: selector-extend(":current(.c)", ".c", ":current(.d, .e)")}

Expand Down Expand Up @@ -425,11 +415,6 @@ a {

<===>
================================================================================
<===> prefixed/same_prefix_in_extender/options.yml
---
:todo:
- sass/libsass#3069

<===> prefixed/same_prefix_in_extender/input.scss
a {b: selector-extend(":-ms-matches(.c)", ".c", ":-ms-matches(.d, .e)")}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
<===> options.yml
---
:todo:
- sass/libsass#3154

<===> README.md
Because `:is()` is extremely flexible, there are more cases where it is
technically a superselector or subselector than those represented here. However,
Expand All @@ -18,6 +13,10 @@ Most changes here should also be reflected in `matches.hrx`.

<===>
================================================================================
<===> simple/equal/options.yml
:todo:
- sass/libsass#3154

<===> simple/equal/input.scss
a {b: is-superselector(":is(c)", "c")}

Expand All @@ -38,6 +37,10 @@ a {

<===>
================================================================================
<===> compound/superset/options.yml
:todo:
- sass/libsass#3154

<===> compound/superset/input.scss
a {b: is-superselector(":is(c.e)", "c.d.e")}

Expand Down Expand Up @@ -115,6 +118,10 @@ check on those two selectors in isolation.

<===>
================================================================================
<===> both/superset/options.yml
:todo:
- sass/libsass#3154

<===> both/superset/input.scss
a {b: is-superselector(":is(c d, e f, g h)", ":is(c d.i, e j f)")}

Expand Down
10 changes: 0 additions & 10 deletions spec/core_functions/selector/replace.hrx
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,6 @@ a {

<===>
================================================================================
<===> format/input/multiple_extendees/list/options.yml
---
:todo:
- sass/libsass#3067

<===> format/input/multiple_extendees/list/input.scss
a {b: selector-replace("c.d", "c, .d", ".e")}

Expand All @@ -159,11 +154,6 @@ a {

<===>
================================================================================
<===> format/input/multiple_extendees/list_of_compound/options.yml
---
:todo:
- sass/libsass#3067

<===> format/input/multiple_extendees/list_of_compound/input.scss
a {b: selector-replace("c.d.e.f", "c.d, .e.f", ".g")}

Expand Down
7 changes: 0 additions & 7 deletions spec/core_functions/selector/unify/simple/pseudo.hrx
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,6 @@ a {
b: :first-letter;
}

<===>
================================================================================
<===> arg/options.yml
---
:todo:
- sass/libsass#3068

<===>
================================================================================
<===> arg/class/same/input.scss
Expand Down
4 changes: 4 additions & 0 deletions spec/css/moz_document/functions/static.hrx
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
<===> options.yml
:warning_todo:
- libsass

<===> input.scss
@-moz-document url(sass-lang.com) {
a {type: unquoted url}
Expand Down
4 changes: 4 additions & 0 deletions spec/css/moz_document/multi_function.hrx
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
<===> options.yml
:warning_todo:
- libsass

<===> input.scss
@-moz-document url(http://www.w3.org/),
url-prefix(http://www.w3.org/Style/),
Expand Down
3 changes: 0 additions & 3 deletions spec/css/moz_document/options.yml

This file was deleted.

21 changes: 13 additions & 8 deletions spec/css/selector.hrx
Original file line number Diff line number Diff line change
Expand Up @@ -80,24 +80,23 @@

<===>
================================================================================
<===> inline_comments/options.yml
---
:todo:
- sass/libsass#3124

<===> inline_comments/silent/input.sass
<===> inline_comments/silent/comma_before/input.sass
a, // comment
b
x: y

<===> inline_comments/silent/output.css
<===> inline_comments/silent/comma_before/output.css
a,
b {
x: y;
}

<===>
================================================================================
<===> inline_comments/silent/with_comma_in_comment/options.yml
:warning_todo:
- sass/libsass#3124

<===> inline_comments/silent/with_comma_in_comment/input.sass
// A comma within a comment, even at the end of the line, should not cause the
// parser to continue the selector on a new line, so this should parse as an
Expand All @@ -112,7 +111,7 @@ b {
}

<===> inline_comments/silent/with_comma_in_comment/warning
WARNING on line 4, column 1 of input.sass:
WARNING on line 4, column 1 of input.sass:
This selector doesn't have any properties and won't be rendered.
,
4 | a // comment,
Expand All @@ -121,6 +120,10 @@ This selector doesn't have any properties and won't be rendered.

<===>
================================================================================
<===> inline_comments/loud/comma_before/options.yml
:todo:
- sass/libsass#3124

<===> inline_comments/loud/comma_before/input.sass
a, /* comment */
b
Expand Down Expand Up @@ -152,6 +155,8 @@ b {
:todo:
- sass/libsass#3154

<===>
================================================================================
<===> placeholder/pseudoselectors/is/solo/input.scss
// Since `%b` doesn't exist, no selectors can match it, so this rule should be
// removed.
Expand Down
5 changes: 0 additions & 5 deletions spec/directives/import/error/not_found.hrx
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
<===> no_extension/options.yml
---
:todo:
- libsass

<===> no_extension/input.scss
@import "other";

Expand Down
3 changes: 0 additions & 3 deletions spec/libsass-closed-issues/issue_1231/options.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
<===> options.yml
---
:warning_todo:
- libsass

<===> input.scss
$input: "foo#{'ba' + 'r'}baz";
.result {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
<===> options.yml
---
:warning_todo:
- libsass

<===> input.scss
$input: "foo#{'ba' + 'r'}baz";
.result {
Expand Down

0 comments on commit 7fd8944

Please sign in to comment.