Activate passing libsass spec tests #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgreter
commented
Dec 24, 2016
mgreter
commented
- Functions named calc() or -*-calc() should not be called libsass#1706
- Generic wrapped selector should only accept pseudo expressions libsass#2056
- Incorrect Comparison of Inline Interpolated String Values libsass#2261
This was referenced Dec 28, 2016
xzyfer
added a commit
to sass/libsass
that referenced
this pull request
Dec 28, 2016
This fix was annoyingly bundled with the reference counted AST PR (#2222). As a result it was not back ported to 3.4, which caused sass/sass-spec#1022 to start failing the 3.4 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.