Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for nested media queries #1230

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Add specs for nested media queries #1230

merged 2 commits into from
Mar 16, 2018

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Mar 16, 2018

See sass/libsass#2425
See sass/dart-sass#244

[skip dart-sass]

This consolidates media tests from spec/scss and spec/scss-tests into
spec/scss/media.
@nex3 nex3 force-pushed the media branch 2 times, most recently from 855defa to 874d4c6 Compare March 16, 2018 22:32
@nex3 nex3 merged commit 63a0d6f into master Mar 16, 2018
@nex3 nex3 deleted the media branch March 16, 2018 23:23
@xzyfer
Copy link
Contributor

xzyfer commented Mar 28, 2018

Does this mean the Ruby Sass implementation was already correct?

@nex3
Copy link
Contributor Author

nex3 commented Apr 4, 2018

Yes.

@xzyfer
Copy link
Contributor

xzyfer commented Apr 4, 2018

Thanks. Looks like it was just a typo on in LibSass then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants