Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates tests for sass/libsass#2775 #1319

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Updates tests for sass/libsass#2775 #1319

merged 2 commits into from
Dec 5, 2018

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Dec 1, 2018 •
edited
Loading

Updates tests for sass/libsass#2775.

The newly passing tests have been updated with --interactive --probe-todo. These tests are:

/spec/selector-functions/unify/universal_simple
/spec/extend-tests/237_extend_with_universal_selector_different_namespace
/spec/extend-tests/040_test_universal_unification_with_namespaced_element_target
/spec/extend-tests/053_test_element_unification_with_namespaced_universal_target
/spec/extend-tests/236_extend_with_universal_selector_empty_namespace
/spec/extend-tests/096_test_long_extender_runs_unification
/spec/extend-tests/060_test_element_unification_with_namespaceless_element_target
/spec/extend-tests/051_test_element_unification_with_namespaceless_universal_target
/spec/extend-tests/038_test_universal_unification_with_namespaceless_element_target
/spec/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
/spec/extend-tests/031_test_universal_unification_with_namespaced_universal_target
/spec/extend-tests/062_test_element_unification_with_namespaced_element_target

output_styles tests have been updated with the following script using Ruby Sass 3.7.2:

set -euo pipefail

declare -ra COMPRESSED=(
sass-spec/spec/output_styles/compressed/extend-tests/094_test_long_extendee_runs_unification
sass-spec/spec/output_styles/compressed/selector-functions/unify/universal_simple
sass-spec/spec/output_styles/compressed/extend-tests/096_test_long_extender_runs_unification
sass-spec/spec/output_styles/compressed/extend-tests/051_test_element_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/038_test_universal_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compressed/extend-tests/040_test_universal_unification_with_namespaced_element_target
sass-spec/spec/output_styles/compressed/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/031_test_universal_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/060_test_element_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compressed/extend-tests/053_test_element_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/235_extend_with_universal_selector
sass-spec/spec/output_styles/compressed/selector-functions/unify/base
sass-spec/spec/output_styles/compressed/extend-tests/062_test_element_unification_with_namespaced_element_target
)

declare -ra NESTED=(
sass-spec/spec/output_styles/nested/extend-tests/038_test_universal_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/nested/extend-tests/040_test_universal_unification_with_namespaced_element_target
sass-spec/spec/output_styles/nested/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/nested/extend-tests/053_test_element_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/nested/extend-tests/235_extend_with_universal_selector
sass-spec/spec/output_styles/nested/extend-tests/096_test_long_extender_runs_unification
sass-spec/spec/output_styles/nested/extend-tests/051_test_element_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/nested/selector-functions/unify/base
sass-spec/spec/output_styles/nested/extend-tests/062_test_element_unification_with_namespaced_element_target
sass-spec/spec/output_styles/nested/extend-tests/031_test_universal_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/nested/extend-tests/094_test_long_extendee_runs_unification
sass-spec/spec/output_styles/nested/extend-tests/060_test_element_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/nested/selector-functions/unify/universal_simple
)

declare -ra COMPACT=(
sass-spec/spec/output_styles/compact/extend-tests/040_test_universal_unification_with_namespaced_element_target
sass-spec/spec/output_styles/compact/selector-functions/unify/universal_simple
sass-spec/spec/output_styles/compact/extend-tests/053_test_element_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compact/extend-tests/096_test_long_extender_runs_unification
sass-spec/spec/output_styles/compact/extend-tests/038_test_universal_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compact/selector-functions/unify/base
sass-spec/spec/output_styles/compact/extend-tests/235_extend_with_universal_selector
sass-spec/spec/output_styles/compact/extend-tests/060_test_element_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compact/extend-tests/051_test_element_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/compact/extend-tests/031_test_universal_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compact/extend-tests/062_test_element_unification_with_namespaced_element_target
sass-spec/spec/output_styles/compact/extend-tests/094_test_long_extendee_runs_unification
sass-spec/spec/output_styles/compact/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
)

for f in ${COMPRESSED[@]}; do
  sass -t compressed $f/input.scss > $f/output.css
done

for f in ${NESTED[@]}; do
  sass -t nested $f/input.scss > $f/output.css
done

for f in ${COMPACT[@]}; do
  sass -t compact $f/input.scss > $f/output.css
done

Skip libsass

@glebm
Updates output_styles tests for sass/libsass#2775
d8415a7 
Test data update for sass/libsass#2775.

Generated from Ruby Sass 3.7.2 with the following script:

```bash

set -euo pipefail

declare -ra COMPRESSED=(
sass-spec/spec/output_styles/compressed/extend-tests/094_test_long_extendee_runs_unification
sass-spec/spec/output_styles/compressed/selector-functions/unify/universal_simple
sass-spec/spec/output_styles/compressed/extend-tests/096_test_long_extender_runs_unification
sass-spec/spec/output_styles/compressed/extend-tests/051_test_element_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/038_test_universal_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compressed/extend-tests/040_test_universal_unification_with_namespaced_element_target
sass-spec/spec/output_styles/compressed/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/031_test_universal_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/060_test_element_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compressed/extend-tests/053_test_element_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compressed/extend-tests/235_extend_with_universal_selector
sass-spec/spec/output_styles/compressed/selector-functions/unify/base
sass-spec/spec/output_styles/compressed/extend-tests/062_test_element_unification_with_namespaced_element_target
)

declare -ra NESTED=(
sass-spec/spec/output_styles/nested/extend-tests/038_test_universal_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/nested/extend-tests/040_test_universal_unification_with_namespaced_element_target
sass-spec/spec/output_styles/nested/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/nested/extend-tests/053_test_element_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/nested/extend-tests/235_extend_with_universal_selector
sass-spec/spec/output_styles/nested/extend-tests/096_test_long_extender_runs_unification
sass-spec/spec/output_styles/nested/extend-tests/051_test_element_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/nested/selector-functions/unify/base
sass-spec/spec/output_styles/nested/extend-tests/062_test_element_unification_with_namespaced_element_target
sass-spec/spec/output_styles/nested/extend-tests/031_test_universal_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/nested/extend-tests/094_test_long_extendee_runs_unification
sass-spec/spec/output_styles/nested/extend-tests/060_test_element_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/nested/selector-functions/unify/universal_simple
)

declare -ra COMPACT=(
sass-spec/spec/output_styles/compact/extend-tests/040_test_universal_unification_with_namespaced_element_target
sass-spec/spec/output_styles/compact/selector-functions/unify/universal_simple
sass-spec/spec/output_styles/compact/extend-tests/053_test_element_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compact/extend-tests/096_test_long_extender_runs_unification
sass-spec/spec/output_styles/compact/extend-tests/038_test_universal_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compact/selector-functions/unify/base
sass-spec/spec/output_styles/compact/extend-tests/235_extend_with_universal_selector
sass-spec/spec/output_styles/compact/extend-tests/060_test_element_unification_with_namespaceless_element_target
sass-spec/spec/output_styles/compact/extend-tests/051_test_element_unification_with_namespaceless_universal_target
sass-spec/spec/output_styles/compact/extend-tests/031_test_universal_unification_with_namespaced_universal_target
sass-spec/spec/output_styles/compact/extend-tests/062_test_element_unification_with_namespaced_element_target
sass-spec/spec/output_styles/compact/extend-tests/094_test_long_extendee_runs_unification
sass-spec/spec/output_styles/compact/extend-tests/029_test_universal_unification_with_namespaceless_universal_target
)

for f in ${COMPRESSED[@]}; do
  sass -t compressed $f/input.scss > $f/output.css
done

for f in ${NESTED[@]}; do
  sass -t nested $f/input.scss > $f/output.css
done

for f in ${COMPACT[@]}; do
  sass -t compact $f/input.scss > $f/output.css
done
```
@glebm glebm changed the title [WIP] Updates output_styles tests for sass/libsass#2775 Updates tests for sass/libsass#2775 Dec 1, 2018
@glebm glebm force-pushed the update-for-ast-sel-cmp branch from d7dafa0 to a626f82 Compare December 1, 2018 18:20
@glebm glebm force-pushed the update-for-ast-sel-cmp branch from a626f82 to 07b131e Compare December 1, 2018 18:26
@glebm glebm mentioned this pull request Dec 1, 2018
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Dec 5, 2018

Kicking of a rebuild with the upstream changes merged

@xzyfer xzyfer merged commit 962d60f into sass:master Dec 5, 2018
@glebm glebm deleted the update-for-ast-sel-cmp branch December 5, 2018 23:10
@glebm glebm mentioned this pull request Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glebm @xzyfer