Add tests for quote
#1380
Merged
Add tests for quote
#1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Apr 13, 2019
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Apr 13, 2019
|
In the future, the libsass PR should be merged first so we don't break the libsass build |
glebm
added a commit
to sass/libsass
that referenced
this pull request
Apr 15, 2019
nex3
reviewed
Apr 17, 2019
There was a problem hiding this comment.
This file should be spec/core_functions/string/quote.hrx (as per DO organize specs by which part of the language they test).
@mgreter Please also don't merge PRs before the assigned reviewer has a chance to review, especially while we're all still getting used to the style guide.
glebm
added a commit
that referenced
this pull request
Apr 19, 2019
glebm
added a commit
that referenced
this pull request
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs sass/libsass#2811
[skip libsass]
libsass PR: sass/libsass#2873