[Color 4] Add tests for lab()
#1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
approved these changes
Sep 28, 2023
| a {b: lab(1px 2 3)} | ||
|
|
||
| <===> unit/lightness/error | ||
| Error: $lightness: Expected 1px to have no units or "%". |
There was a problem hiding this comment.
Nit: unrelated to the change, but when I read "expected 1px have no units or %" It makes me think that the number shouldn't have units and that it also shouldn't have percent (some users might not think of percent as a unit).
So I wonder if that could be reworded (maybe on a separate PR?) to something like.. Expected 1px to have no units or to have "%". or Expected 1px to have "%" or no units. or something like that 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs error output, but Dart Sass currently doesn't support
missing alpha channels or the is-missing() function so they can't be
generated yet.
See sass/sass#2831
[skip dart-sass]