Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color 4] Add tests for missing channels in legacy color spaces #1948

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[Color 4] Add tests for missing channels in legacy color spaces #1948

merged 1 commit into from
Oct 17, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 11, 2023 •
edited

This also adds tests for the global hwb() function.

[skip dart-sass]

@nex3 nex3 mentioned this pull request Oct 11, 2023
Merged
@nex3
[Color 4] Add tests for missing channels in legacy color spaces
b2a1b61 
This also adds tests for the global hwb() function.
@nex3 nex3 marked this pull request as ready for review October 13, 2023 23:24
@nex3 nex3 requested a review from jathak October 13, 2023 23:24
@nex3 nex3 merged commit e409a92 into feature.color-4 Oct 17, 2023
12 checks passed
@nex3 nex3 deleted the legacy-missing branch October 17, 2023 22:00
jgerigmeyer added a commit to oddbird/sass-spec that referenced this pull request Oct 18, 2023
@jgerigmeyer
Merge branch 'feature.color-4' into js-api-color-4
9a9cae9 
* feature.color-4:
  [Color 4] Add tests for missing channels in legacy color spaces (sass#1948)
  [Color 4] Add tests for oklch() (sass#1945)
  [Color 4] Add tests for the color() function (sass#1943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nex3 @jathak