Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Package Importer] Specs #1952
[Package Importer] Specs #1952
Changes from 53 commits
ddd98e7
b489a76
20ebaab
51214a6
db1db07
40f30ae
f4748eb
68eabbb
447ac0e
25500cb
a024ff0
fad1cc3
f5e413c
1ddd748
cbf39fb
c98b9ba
3466dc6
5e04ad9
7b9743f
83dc0a7
ccd2a77
b49db2c
f96ba8d
88d5ae6
551b5b7
3bbb918
4230a0a
137c8f9
5a6382e
3d66845
4308648
75b02ad
5b38195
247a136
0cd68eb
41f3416
fd4fac4
31b757a
70241b4
1a292f5
a31051f
ad97abb
654b451
3fdd163
bee93ca
2b6a3c5
a6cdbdf
46b38be
5f76314
27ee25b
7860a91
b5edacb
3f435d7
a01db2a
d20e8b4
b18ff2c
7a5e0ce
ce63d68
029ce09
628add2
c841cce
45561f4
adf2f4a
2e5b770
3263bc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just test
new NodePackageImporter()
without passing it tocompileString()
now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in oddbird@b18ff2c