Add tests for CSS round() with one argument
#2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates tests expect global function warnings when calculations are falling back on global Sass functions. See sass/sass#3803 Closes #2036
This was referenced Nov 13, 2024
|
|
||
| , | ||
| 1 | a {b: abs(1 + 1px)} | ||
| | ^^^^^^^ |
There was a problem hiding this comment.
Nit: Shouldn't these point to the function name instead?
There was a problem hiding this comment.
Since the deprecation warning specifically refers to mixing unitless and unit numbers, I think it makes sense to point to the specific location where that mixing occurs.
| ' | ||
| input.scss 1:13 root stylesheet | ||
|
|
||
| DEPRECATION WARNING: In future versions of Sass, round() will be interpreted as a CSS round() calculation. This requires an explicit modulus when rounding numbers with units. If you want to use the Sass function, call math.round() instead. |
There was a problem hiding this comment.
Is a double warning expected here?
There was a problem hiding this comment.
More or less. It's both the case that round(1 + 1px) will throw an error and that round(2px) (which it resolves to) will throw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates tests expect global function warnings when
calculations are falling back on global Sass functions.
See sass/sass#3803
Closes #2036
[skip dart-sass]