Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate specs for issue 1432 #469

Closed
wants to merge 1 commit into from
Closed

Activate specs for issue 1432 #469

wants to merge 1 commit into from

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Aug 10, 2015

This PR activates specs for sass/libsass#1432

This was referenced Aug 10, 2015
Merged
Closed
@saper
Copy link
Member

saper commented Sep 20, 2015

We have a difference in error messages here:

-"Error: $selector: null is not a string for `simple-selectors'"
+"Error: $selector: null is not a valid selector: it must be a string,"

This was referenced Sep 20, 2015
Closed
Closed
saper added a commit to saper/sass-spec that referenced this pull request Sep 20, 2015
@saper
Update status of tests (todo/closed)
4b835c5 
The following tests from "closed" need
to be moved back to "todo":

sass#404
sass#469
@saper saper mentioned this pull request Sep 20, 2015
Merged
@xzyfer xzyfer mentioned this pull request Sep 21, 2015
Closed
@xzyfer
Copy link
Contributor Author

xzyfer commented Sep 21, 2015

Tracking difference in sass/libsass#1563

@saper saper mentioned this pull request Sep 21, 2015
Closed
saper added a commit to saper/sass-spec that referenced this pull request Sep 21, 2015
@saper
Update status of tests (todo/closed)
228ad48 
The following tests from "closed" need
to be moved back to "todo":

sass#404
sass#469
@saper saper closed this Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
error-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzyfer @saper