-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for error output #494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2015
As the Travis shows, this change work only with adding compiler via the |
This should be enough for rudimentary error testing. Should we need more, we should be aware of the following limitations:
|
This was referenced Sep 20, 2015
Merged
Closed
Closed
Convert --skip/-s to no-op, as this is now the default behavior. Rationale: As we now expect errors to be thrown by the spec scripts it makes no sense to stop whenever a first error is encountered. Unfortunately we cannot print deprecation warning in order not to break formats like tap or mess with stderr (Windows PowerShell thinks for example that if there is anything on stderr, the command failed).
We cannot run tests in parallel when redirecting $stderr into a single buffer Fixes: sass#499
If files "error" and "status" are existing in the test directory, do expect errors and test against them. The errors returned by the Sass engines are now treated as test failures (not fatal errors). --unexpected-pass reports an error whenever a test marked as "todo" does pass. Failing "todo" errors are silently marked as "passed". Also re-create output test files with --nuke. "status" and "error" files are re-created if necessary. Any failures will be reported in this case normally. Fixes: sass#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable testing for error output
and sass compiler failures.
If files "error" and "status" are existing
in the test directory, do expect errors
and test against them.
Errors returned by the Sass engines are
now treated as test failures, not errors.
Also create error and status files with --nuke.
An error will be reported in this case anyway.
Important Now the tests cannot be ran in parallel,
because we need to capture standard error reliably.
Should fix: #136 #133