Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cancel clock event when kivy app stops #6

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

sassanh
Copy link
Owner

@sassanh sassanh commented Dec 19, 2023

After exiting the Kivy app, the scheduler should stop rendering frames as all framebuffers, etc are unavailable at this stage. This is causing an issue in ubo-app when it manually triggers another tick of Clock after app is finished and FinishAction is dispatched.

Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. please merge

@sassanh sassanh merged commit 82d5513 into main Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants