refactor: HeadlessWidget is not a singleton anymore, config migrated to config module
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid segmentation fault
sassanh
changed the title
HeadlessWidget is not a singleton anymore, config module is now source of truth for configHeadlessWidget is not a singleton anymore, config migrated to config module
…d to config module refactor: initializing display and config is now done in `setup_headless_kivy` feat: class method `get_instance` to get the closest parent instance of type `HeadlessWidget`
sassanh
force-pushed
the
refactor
branch
3 times, most recently
from
014d7b7
to
6a2b6fc
Compare
mehrdadfeller
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to have multiple
HeadlessWidgetinstances in the same app. Theconfigmodule is now the source of truth for the config, and theHeadlessWidgetclass is now a regular Kivy widget. Thesetup_headless_kivyfunction is now responsible for initializing the display and the config.It makes it easier to write tests for software that uses
HeadlessWidget.It is also a step towards having display only redraw the parts of the screen that have changed.