Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3 #14

Closed
pombredanne opened this issue Mar 14, 2019 · 5 comments
Closed

Support Python 3 #14

pombredanne opened this issue Mar 14, 2019 · 5 comments

Comments

@pombredanne
Copy link
Contributor

We are working on the Python3 port of Scancode and this library will need to be updated accordingly to support Python3.

For now there are issues such as

pymaven/pymaven/utils.py

Line 19 in b744bbe

from urlparse import urlsplit, urlunsplit 

    from urlparse import urlsplit, urlunsplit
ModuleNotFoundError: No module named 'urlparse'
@pombredanne
Copy link
Contributor Author

@wfscheper It looks like scancode and your tools are the only two users of pymaven so far. Are you still willing to maintain it? Otherwise I am fine ti take it over. Alternatively I can just maintain my fork too.

@wfscheper wfscheper reopened this Mar 15, 2019
@wfscheper
Copy link
Contributor

Whoops. Hit the wrong button. I'm taking at look what it will take to add python3 support.

@wfscheper
Copy link
Contributor

So PR #13 adds python3 support, but I left it un-merged for you to review. Guess we both got busy with other things. Shall I merge that now?

@pombredanne
Copy link
Contributor Author

@wfscheper let me quickly review this at last!

@wfscheper
Copy link
Contributor

Fixed by #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wfscheper @pombredanne