Clientless pom #13
Merged
Clientless pom #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove conary-isms and use pbr.
Use six for compatibility between python2 and python3 and tox for running tests. Biggest source of actual code change is around supporting rich comparision methods in python3.
Adds the classmethods Pom.fromstring and Pom.parse. These are modeled on the lxml.etree functions of the same name. If a MavenClient is passed in, then the resulting Pom object will attempt to dynamically load data from external POM files available via the client. Sem-Ver: feature Fixes: sassoftware#4
Ensure that our LICENSE file is correctly packaged and installed.
Use tempfile.mkdtemp to create the cacheDir rather than assuming we can use /tmp.
Prefer a handwritten changelog to pbr's dump of the git history.
Signed-off-by: Walter Scheper <Walter.Scheper@sas.com>
|
@pombredanne, do you have any comments or concerns with this implementation before I merge it? |
|
@wfscheper Thanks ++! |
Closed
|
@wfscheper I guess I had forgotten about this: shame on me! Let me review at last. Thank you! |
|
@wfscheper this is all good for me. I will rebase any pending things and patches I had on this once you merge it is and will send a PR your way |
|
Thank you ++ |
wfscheper
added a commit
that referenced
this pull request
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using the pymaven Pom object without a maven client.
Fixes #4, #7