Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix copyright check script #344

Merged
merged 5 commits into from
Jun 19, 2023
Merged

fix: fix copyright check script #344

merged 5 commits into from
Jun 19, 2023

Conversation

scottdover
Copy link
Contributor

@scottdover scottdover commented Jun 16, 2023

Summary
This updates our copyright check script to run on all valid files, instead of those added in a recent commit. You can run this check manually via npm run copyright:check. This is also ran via github actions.

Additionally, this adds a fix flag (npm run copyright:check --fix) that will automatically prepend copyright information to files that are missing it.

Testing

  • Make sure github actions fails build (on first commit)
  • Make sure github actions passed on next build (after running --fix)
  • Make sure copyright appears on files

Copy link
Contributor

@smorrisj smorrisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for doing this. I was wondering why my new files for the sas 9 local changes didnt error out the PR check. Will fix those after this merges

Copy link
Member

@scnwwu scnwwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

CHANGELOG.md Outdated

### Added

- Added support for `npm run copyright:check --fix`. This automatically prepends files with the corrrect copyright information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo for correct

@scottdover scottdover merged commit 3a1e322 into main Jun 19, 2023
@scottdover scottdover deleted the fix/copyright-check branch June 19, 2023 17:43
@scnwwu scnwwu added this to the 1.1.0 milestone Jul 3, 2023
@Becky-Williamson Becky-Williamson added the testing Test the pull requests label Jul 6, 2023
@Becky-Williamson Becky-Williamson self-assigned this Jul 6, 2023
@Zhirong2022 Zhirong2022 added testing-complete Complete the pull requests testing and removed testing Test the pull requests labels Jul 7, 2023
@Becky-Williamson
Copy link

Scott walked me though the changes for copyright-check and demonstrated how the build will fail if the copyright information is not included in the file. They then demoed the copyright check fix and rebuilt successfully when it was completed.

@Zhirong2022 Zhirong2022 added verified ready for release Code pushed, but not released in VS code marketplace yet and removed testing-complete Complete the pull requests testing verified labels Jul 27, 2023
@tianliang657 tianliang657 added the interactive Issue could not be covered by automation test label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interactive Issue could not be covered by automation test ready for release Code pushed, but not released in VS code marketplace yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants