-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix copyright check script #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for doing this. I was wondering why my new files for the sas 9 local changes didnt error out the PR check. Will fix those after this merges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
CHANGELOG.md
Outdated
|
||
### Added | ||
|
||
- Added support for `npm run copyright:check --fix`. This automatically prepends files with the corrrect copyright information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo for correct
Scott walked me though the changes for copyright-check and demonstrated how the build will fail if the copyright information is not included in the file. They then demoed the copyright check fix and rebuilt successfully when it was completed. |
Summary
This updates our copyright check script to run on all valid files, instead of those added in a recent commit. You can run this check manually via
npm run copyright:check
. This is also ran via github actions.Additionally, this adds a fix flag (
npm run copyright:check --fix
) that will automatically prepend copyright information to files that are missing it.Testing
--fix
)