Add option 'warningsAreErrors' for failing on both errors AND warnings.

[DirtyHairy]

Hi all!

This PR adds an option warningsAreErrors for treating linter warnings as fatal errors.

Cheers
-Christian

[DanPurdy]

Can I ask why? Can't you just set your rules to errors instead of warnings? I'm not sure plugin specific options are the way to go either. Happy to discuss though.

[DirtyHairy]

Hi @DanPurdy !

I agree, you could just bump the severity of all rules to 2 and be done with. However, for me, defining the severity of a violation is complementary to configuring the maximum severity tolerated by the tooling. From a more practical side, this allows to use a single definition file in multiple contexts, i.e. tolerate warnings in development builds while disallowing them in production. To me, this is similar to specifying --max-warnings on the sass-lint command line.

Of course, from this viewpoint, warningsAreErrors is a misnomer, warningsAreFatal would be better (I was going to change this when I noticed your reply). An option maxWarnings similar to the sass-lint options would also be an alternative.

What do you think?

[DanPurdy]

So with the next release of Sass-lint (1.10) you'll be able to use max-warnings in your config / passed in options too so that may achieve what you're looking for if I understand it. Currently yes it's only a CLI option but it will be available to you shortly hopefully.

So you could have your config set as you wish and then just pass in this extra parameter with your build task without requiring a separate grunt specific option. Would that solve this?

If you'd like to try it now you could just point your grunt sass lint package file at our develop branch instead of a NPM release.

[DirtyHairy]

Hi @DanPurdy !

Yes, turning max-warnings is turned into a proper parameter for sass-lint would also solve the problem. I'll give it a try as I find time and keep you updated 😏

Cheers
-Christian

[DanPurdy]

It's already done and will be released in 1.10 which hopefully wont be more than a week or two away.