-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid warning on Mixins should come before declarations when having multiple includes #80
Comments
* Added new tests to test the bug highlighted in sasstools#80 * Added new tests with specific excludes passed in * Added BEM style notation to test for non standard rulesets
Thanks for this report/test case @jjanssen it made tracking the issue a lot easier. Hopefully fixed now, will just await review from the others. |
No problem! Seemed you guys put a lot of effort in this package the past few weeks. So if I can help by narrowing down the use case then it makes it easier for everybody :) |
Update mixin-before-declaration rule fix #80
* Added new tests to test the bug highlighted in sasstools#80 * Added new tests with specific excludes passed in * Added BEM style notation to test for non standard rulesets
Update mixin-before-declaration rule fix sasstools#80
🎉 This issue has been resolved in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I am currently working with sass-lint 1.1.0
When using multiple mixins within a selector the rule for 'Mixins should come before declarations' starts throwing invalid warnings when using 3 or more. In another scenario the prepending selector can also cause this issue to throw a warning.
I have setup this little scss file to reproduce this issue:
This snippet throws the following warning through the CLI
This doesn't occur in the following cases:
.coffee
the warning is gone.@include hello;
. The other includes do not make a difference.The text was updated successfully, but these errors were encountered: