Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable for property options #1128

Merged
merged 2 commits into from
Sep 17, 2017

Conversation

DanPurdy
Copy link
Member

@DanPurdy DanPurdy commented Sep 2, 2017

closes #966

Added two new options to the variable for property rule
allow-map-get to allow the use of map-get() as a property as this technical references a variable
allowed-functions An array of allowed function names you would like to allow the use of in this rule. i.e. my-map-func() to not throw a linter warning when used as a property value.

A new warning message for functions is now available too
'The function passed to \'' + declarationIdent + '\' is not allowed'

<DCO 1.1 Signed-off-by: Dan Purdy dan@dpurdy.me>

@DanPurdy DanPurdy self-assigned this Sep 2, 2017
@DanPurdy DanPurdy changed the title 🔍 Update variable for property options Update variable for property options Sep 2, 2017
@coveralls
Copy link

coveralls commented Sep 2, 2017

Coverage Status

Coverage increased (+0.01%) to 97.583% when pulling 31d8343 on feature_update-variable-for-property into 658f4c4 on v1-dev.

@coveralls
Copy link

coveralls commented Sep 2, 2017

Coverage Status

Coverage increased (+0.01%) to 97.586% when pulling f142793 on feature_update-variable-for-property into 658f4c4 on v1-dev.

@DanPurdy DanPurdy merged commit 72f4cad into v1-dev Sep 17, 2017
@DanPurdy DanPurdy deleted the feature_update-variable-for-property branch September 17, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants