Hotfix Master: Fix overriding default rules #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2015
|
Also just noticed that this addresses #278 to a degree, although the tests will remain to be updated. |
|
👍 Looks good to me |
DanPurdy
force-pushed
the
hotfix/merge-default
branch
from
5df996d
to
3140d18
Compare
|
@benthemonkey had the majority of this working I just found a few small issues on top of that with inline rules and how they interacted with the other rules being set. Looking to get this out with 1.3.1 |
| mixins-before-declarations: 1 | ||
| no-color-literals: 2 | ||
|
|
||
| ~~~ |
There was a problem hiding this comment.
Just that last one! Same issue as before.
bgriffith
added a commit
that referenced
this pull request
Oct 17, 2015
Hotfix Master: Fix overriding default rules
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Hotfix Master: Fix overriding default rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with default rules always being merged into user defined configurations even if
merge-default-rulesis set to false.Fixes #309
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com