Build updates #69
Merged
Build updates #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
astrojuanlu
commented
Jun 28, 2018
astrojuanlu
commented
- Restrict pandas version in Python 3.4 (see Add pyproject.toml pandas-dev/pandas#20775 and related issues)
- Test on Python 3.7 🎉
|
Python 3.7 is not enabled yet: travis-ci/travis-ci#9815 |
astrojuanlu
force-pushed
the
build-updates
branch
from
524adfe to
9db722c
Compare
|
I'm commenting out Python 3.7, since apparently it will be a while until we have proper CI infrastructure there. |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 33 33
Lines 5234 5234
=======================================
Hits 4741 4741
Misses 493 493Continue to review full report at Codecov.
|
arielze
reviewed
Jul 2, 2018
| @@ -23,7 +23,7 @@ | |||
| 'dsnparse', | |||
| 'fiona>=1.7.2,<2.*', | |||
| 'folium', | |||
| 'ipyleaflet', | |||
| 'ipyleaflet!=0.8.2', | |||
There was a problem hiding this comment.
only this specific version is problematic? othe higher and lower are fine?
There was a problem hiding this comment.
astrojuanlu
force-pushed
the
build-updates
branch
from
18edd8e to
8cc871a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.