Fixes error in UpdateSeuratObject due to missing global slot. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojaveazure
force-pushed
the
fix_UpdateSeuratObject
branch
from
bd6a7e9
to
89bf440
Compare
mojaveazure
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Hey Diego,
Sorry for the delay. Thanks for catching this! I've got one small suggestion for handling global to ensure that tSNEs and UMAPs are marked as global reductions (as they are in RunTSNE() and RunUMAP()). If this looks good for you, can you accept the suggestion and I'll get it merged in?
Bump develop version
mojaveazure
approved these changes
Feb 16, 2024
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue in Seurat's UpdateSeuratObject: satijalab/seurat#8019
When updating the DimReduc objects the slot "global" is not initialized, it is only assigned for the default reduction. This fix initializes it to FALSE when running UpdateDimReduction.