Add warning if layer is absent from assay #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to help diagnose issues when assay doesn't have desired layer. For example see satijalab/seurat#8658 and discussion in satijalab/seurat#8659. The warning message might not be the prettiest, but I didn't want to go through `Layer.Seurat` method to get the assay name.
mojaveazure
approved these changes
May 3, 2024
There was a problem hiding this comment.
Hey @maxim-h, sorry for the delay. This looks good, thanks for the addition!
Bump develop version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to help diagnose issues when assay doesn't have desired layer. For example see satijalab/seurat#8658 and discussion in satijalab/seurat#8659, specifically the suggestion from Sam.
The warning message might not be the prettiest, but I didn't want to go through
Layer.Seuratmethod to get the assay name.