Bug fix in PolyVtx()
#194
Merged
Bug fix in PolyVtx()
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `r` (radius), `xc` (x center), and `yc` (y center) to be numeric instead of integers
dcollins15
reviewed
Mar 29, 2024
Comment on lines
+1412
to
+1413
| "'t1' must be a single, finite number" = is_bare_numeric(x = t1, n = 1L) && | ||
| is.finite(x = t1) |
There was a problem hiding this comment.
In the previous version t1 wasn't checked for finiteness - I just want to confirm that this change was intentional 👌
There was a problem hiding this comment.
Yes, this is intentional. It was not checked previously as rlang::is_bare_numeric() does not have a finite parameter like rlang::is_bare_integerish() (and I didn't really know what I was doing with the argument validation)
Also, if the angle is infinite, then the resulting coordinates are all Inf (or -Inf if the angle is infinite and negative); this, to me, doesn't make sense so I want to disallow that behavior
dcollins15
approved these changes
Apr 3, 2024
Bump develop version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
r(radius),xc(x center), andyc(y center) to be numeric instead of integers; also simplify example forPolyVtx()