Subsetting feature-level metadata fix #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojaveazure
approved these changes
Apr 16, 2024
Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsetting features like so
pbmc3k_subset <- subset(pbmc3k, features = features)was not correctly subsetting the feature-level metadata resulting in different variable features in the subsetted object. The code that subsetted the feature-level metadata was running after the features of the object had already been subset, so the new and original features were the same and thus instead of removing the features in place, they were removed from the end of the table.Explained in more detail here: https://github.com/satijalab/project-management/issues/73