Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allowing duplicate keys #26

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Fix allowing duplicate keys #26

merged 3 commits into from
Oct 21, 2021

Conversation

mojaveazure
Copy link
Member

Duplicate keys were being allowed when re-adding an object to a Seurat object
Now, do better checking of duplicate keys
Also includes fixes for Key.Seurat

Error reproducing prior to patch and validation with patch:

library(Seurat)
data("pbmc_small")
pbmc_small[["tsne.xyz"]] <- pbmc_small[["tsne"]]
Key(pbmc_small)
pbmc_small[["tsne.xyz"]] <- pbmc_small[["tsne"]]
Key(pbmc_small)

@mojaveazure
Fix allowing duplicate keys
bb468e7 
Duplicate keys were being allowed when re-adding an object to a Seurat object
Now, do better checking of duplicate keys
@mojaveazure mojaveazure merged commit fecdd6a into develop Oct 21, 2021
@mojaveazure mojaveazure deleted the fix/doublekey branch October 21, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoast timoast timoast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mojaveazure @timoast