Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything is broken #67

Closed
HannanSolo opened this issue Jan 4, 2018 · 6 comments
Closed

Everything is broken #67

HannanSolo opened this issue Jan 4, 2018 · 6 comments

Comments

@HannanSolo
Copy link

After this sudden change, everything in my code will NOT work. Not even build with docker

All I get is this multiple-value uuid.NewV4() in single-value context

@HorizonChM
Copy link

me too ......

@mpecan
Copy link

mpecan commented Jan 4, 2018

uuid := uuid.NewV4()

changes to

uuid, err := uuid.NewV4()

I have the same issue, but the new format actually complies with the Go guidelines better, so I guess we will just have to change and adapt.

@snedzad
Copy link

snedzad commented Jan 4, 2018

If the reason is really the need for compliance it's a terrible one. It's breaking everyone's code just to have some compliance achieved. You should've made v2 and put changes there.

@ivucica
Copy link

ivucica commented Jan 4, 2018

See also original bug #18 and maybe consider continuing this discussion in #66

@kataras
Copy link

kataras commented Jan 4, 2018

@satori Can you create a branch based on that commit: 5bf94b69c6b68ee1b541973bb8e1144db23a194b? This will fix some issues that dep users have with iris, although Iris has vendored the go.uuid a long time ago and has not any problems for its session databases or internal packages but dep tool doesn't care about the .lock file there so I have to update the gopkg.toml with branch="v1.2.0" I propose you to create which will point before that breaking API, thank you very much!

@satori
Copy link
Owner

satori commented Jan 10, 2018

Closing as a duplicate of #66

@kataras I've tagged v1.2.0 as last commit before API has changed but contains some bug fixes and improvements.

@satori satori closed this as completed Jan 10, 2018
kevinburke added a commit to kevinburke/go.uuid that referenced this issue Jan 25, 2018
This new function can support the desired feature (return error
instead of panic) without having to break compatibility for existing
clients.

Fixes satori#66.
Fixes satori#67.
Fixes satori#68.
Fixes satori#69.
Fixes satori#70.
bcho added a commit to sundayfun/aliyun-sts-go-sdk that referenced this issue Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants