Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(satori): fix impl about resource elements, fix #198, fix #217 #223

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

shigma
Copy link
Contributor

@shigma shigma commented Jan 8, 2024

  • image -> img
  • url -> src

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6390012) 86.08% compared to head (cf0ea11) 86.11%.
Report is 1 commits behind head on master.

Files Patch % Lines
packages/element/src/index.ts 33.33% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   86.08%   86.11%   +0.02%     
==========================================
  Files           1        1              
  Lines         503      504       +1     
  Branches      111      111              
==========================================
+ Hits          433      434       +1     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shigma shigma changed the title fix(satori): fix incorrect impl about resource elements, fix #198, fix #217 fix(satori): fix impl about resource elements, fix #198, fix #217 Jan 8, 2024
@shigma shigma merged commit 014583e into master Jan 8, 2024
8 checks passed
@shigma shigma deleted the fix-res-elm branch January 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants