fix(telegram): Invalid URL when enabled files.local #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shigma
approved these changes
May 29, 2024
idranme
reviewed
May 30, 2024
adapters/telegram/src/bot.ts
Outdated
| @@ -144,7 +144,7 @@ export class TelegramBot<C extends Context = Context, T extends TelegramBot.Conf | |||
|
|
|||
| async $getFile(filePath: string) { | |||
| if (this.local) { | |||
| return await this.ctx.http.file(filePath) | |||
| return await this.ctx.http.file(`file://${filePath}`) | |||
There was a problem hiding this comment.
On Windows, should file:/// be used?
On Windows, the first character of the path is the disk drive letter, not /.
There was a problem hiding this comment.
Actuall it should be pathToFileURL. I'll fix it.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Actuall it should be
pathToFileURL. I'll fix it.
Is #78 still relevant? I mean if it is, maybe you should not directly use Node APIs.
There was a problem hiding this comment.
Is #78 still relevant? I mean if it is, maybe you should not directly use Node APIs.
pathToFileURL can be ponyfilled in the browser.
https://github.com/cordiverse/ponyfills/blob/main/packages/url/src/index.ts
shigma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run telegram-bot-api with
--localargument and enablefiles.localconfig in Koishi. When I use any API that returns a file (e.g.getUserwill return user's avatar), I will get aTypeError: Invalid URLerror like this.No any
\nin the log as above.***in the path is my bot token.The PR fixes this, tested on Windows and Linux.