Raises errors when giving encryption as non-Hash object

fix ruby-ldap#250
satoryu · Jan 13, 2016 · 717c307 · 717c307
1 parent f1659c5
commit 717c307
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/net/ldap.rb b/lib/net/ldap.rb
@@ -540,6 +540,9 @@ def initialize(args = {})
     @base = args[:base] || DefaultTreebase
     @force_no_page = args[:force_no_page] || DefaultForceNoPage
     @encryption = args[:encryption] # may be nil
+    if !@encryption.nil? and !@encryption.is_a?(Hash)
+      raise ArgumentError, "encryption must be given as Hash"
+    end
     @connect_timeout = args[:connect_timeout]
 
     if pr = @auth[:password] and pr.respond_to?(:call)

diff --git a/test/test_ldap.rb b/test/test_ldap.rb
@@ -91,4 +91,10 @@ def test_encryption
 
     assert_equal enc[:method], :start_tls
   end
+
+  def test_initialize
+    assert_raise ArgumentError, "encryption must be given as Hash" do
+      Net::LDAP.new encryption: [ :simple_tls ]
+    end
+  end
 end