-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zone to tribun news api #12
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/satyawikananda/berita-api/Cu14QpK2jowWHzZCEXqkRmMBpy2v |
Hi, thanks for your contribution, I have checked this and for some zone that doesn't has some types, I think we can add some response, for example:
What do you think? |
Absolutely agree. I will add it soon |
Hi @satyawikananda, I found that every missing type will throw error message |
Yes, I think that's enough. Tell me if this PR is ready to merge :) |
Yeah thanks, this PR is ready for merge. I have another enhancement, but it's better to discuss later on different issue |
Yes, if you have another enhancement again, you can create an issue again. Anyway, thank you for your contributions here :) I'll merge this. |
@all-contributors please add @axmad386 for code, bug and ideas |
I've put up a pull request to add @axmad386! 🎉 |
Wow, I don't know what is this, but thank you 😄 |
This PR is to fix #10 and add zone params to api TribunNews
Currently, main rss API tribunnews is not support with params type, but it's work with subdomain api
api.tribunnews/:type
=> 404:zone.tribunnews/:type
=> 200In this PR, we add additional route for tribunnews, so we can access them with:
BASEURL/v1/tribun-news
(get list news on main api)BASEURL/v1/tribun-news/:zone
(get list news on zone api)BASEURL/v1/tribun-news/:zone/:type
(get list news on zone api with type)NOTE: some zone doesnt have some type, may be we can discuss later how to handle it