Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): add vice indonesia api #19

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

danarn17
Copy link
Contributor

@danarn17 danarn17 commented Oct 6, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/satyawikananda/berita-api/FRxnJDf9einZEStK58JdFZ6GHtna
✅ Preview: https://berita-api-git-fork-danarn17-add-vice-api-satyawikananda.vercel.app

@satyawikananda
Copy link
Owner

Thanks for your contribution, I'll review this now.

@satyawikananda
Copy link
Owner

Is there any categories for this Vice News? I just want to make sure.

@satyawikananda satyawikananda added the enhancement New feature or request label Oct 7, 2021
@danarn17
Copy link
Contributor Author

danarn17 commented Oct 7, 2021

Is there any categories for this Vice News? I just want to make sure.

No, there isn't. Based on their docs (https://api-docs.vice.com/) all endpoints need authentication except for rss and I don't think it's free

@satyawikananda
Copy link
Owner

Okay I see, can you add that new API to list routes in the readme file, just for documentation, and also, I'll add hacktoberfest-accepted label for you.

@danarn17
Copy link
Contributor Author

danarn17 commented Oct 7, 2021

Okay I see, can you add that new API to list routes in the readme file, just for documentation, and also, I'll add hacktoberfest-accepted label for you.

Sure. Thank You.

@danarn17 danarn17 closed this Oct 7, 2021
@satyawikananda satyawikananda reopened this Oct 7, 2021
@satyawikananda
Copy link
Owner

Please don't close this PR, I'm haven't merge this PR yet. 😅

@satyawikananda
Copy link
Owner

Okay LGTM. Thanks for your contributions :)

@satyawikananda satyawikananda changed the title add vice indonesia api feat(API): add vice indonesia api Oct 7, 2021
@satyawikananda satyawikananda merged commit a5ef51a into satyawikananda:main Oct 7, 2021
@satyawikananda
Copy link
Owner

@all-contributors please add @danarn17 for code and doc

@allcontributors
Copy link
Contributor

@satyawikananda

I've put up a pull request to add @danarn17! 🎉

@danarn17
Copy link
Contributor Author

danarn17 commented Oct 7, 2021

Please don't close this PR, I'm haven't merge this PR yet. 😅

Sorry, I hit the wrong button 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants