Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): add Suara News and VOA Indonesia API #21

Merged
merged 9 commits into from
Oct 7, 2021

Conversation

indrapalijama
Copy link
Contributor

hello, just add a new api endpoint for SUARA News, i'd already tested it too.
Unfortunately, suara api only contains 2 type.
I'd already edited the documentation too.

Have a good day

@vercel
Copy link

vercel bot commented Oct 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/satyawikananda/berita-api/676V6axSXKx2xBdieaFzmGfy2Qmr
✅ Preview: https://berita-api-git-fork-indrapalijama-secondary-satyawikananda.vercel.app

@indrapalijama indrapalijama changed the title Add Suara News API Add Suara News and VOA Indonesia API Oct 7, 2021
@indrapalijama
Copy link
Contributor Author

indrapalijama commented Oct 7, 2021

hello, just add a new api endpoint for SUARA News, i'd already tested it too. Unfortunately, suara api only contains 2 type. I'd already edited the documentation too.

Have a good day

edit :

  • add VOA Indonesia api
  • i also noticed that readme.md files (indonesian) still not updated just like existing readme.md so i update it,
  • sorry, please ignore some changes in existing files, must be my default vscode formatter (add empty spaces)
    hope you don't mind. Thanks

@satyawikananda
Copy link
Owner

Hi, thanks for your contributions, I will review this first.

@satyawikananda satyawikananda added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 7, 2021
@satyawikananda
Copy link
Owner

I've reviewed all of that and I've changed the code a bit there, overall is LGTM. Ready to merge

@satyawikananda satyawikananda changed the title Add Suara News and VOA Indonesia API feat(API): add Suara News and VOA Indonesia API Oct 7, 2021
@satyawikananda satyawikananda merged commit 2a94bba into satyawikananda:main Oct 7, 2021
@satyawikananda
Copy link
Owner

@all-contributors please add @indrapalijama for code and doc

@allcontributors
Copy link
Contributor

@satyawikananda

I've put up a pull request to add @indrapalijama! 🎉

@indrapalijama
Copy link
Contributor Author

I've reviewed all of that and I've changed the code a bit there, overall is LGTM. Ready to merge

Thanks, i've noticed that you didn't have an api documentation for your project (openAPI). Do you want me to create it for you? i can try, if you want

@satyawikananda
Copy link
Owner

satyawikananda commented Oct 7, 2021

I've reviewed all of that and I've changed the code a bit there, overall is LGTM. Ready to merge

Thanks, i've noticed that you didn't have an api documentation for your project (openAPI). Do you want me to create it for you? i can try, if you want

Yes, if you want to make it, feel free to make it, because for now documentation in the readme is enough for me :)

Edit: If you want to make it, you can create an issue first and we can discuss it there

@indrapalijama
Copy link
Contributor Author

I've reviewed all of that and I've changed the code a bit there, overall is LGTM. Ready to merge

Thanks, i've noticed that you didn't have an api documentation for your project (openAPI). Do you want me to create it for you? i can try, if you want

Yes, if you want to make it, feel free to make it, because for now documentation in the readme is enough for me :)

Edit: If you want to make it, you can create an issue first and we can discuss it there

Okay! i'd already try to make it, but it seems that i've got into some trouble (integration with typescript )
sure, i'll create an issue later and discuss it more detailed with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants