-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(API): add Suara News and VOA Indonesia API #21
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/satyawikananda/berita-api/676V6axSXKx2xBdieaFzmGfy2Qmr |
edit :
|
Hi, thanks for your contributions, I will review this first. |
I've reviewed all of that and I've changed the code a bit there, overall is LGTM. Ready to merge |
@all-contributors please add @indrapalijama for code and doc |
I've put up a pull request to add @indrapalijama! 🎉 |
Thanks, i've noticed that you didn't have an api documentation for your project (openAPI). Do you want me to create it for you? i can try, if you want |
Yes, if you want to make it, feel free to make it, because for now documentation in the readme is enough for me :) Edit: If you want to make it, you can create an issue first and we can discuss it there |
Okay! i'd already try to make it, but it seems that i've got into some trouble (integration with typescript ) |
hello, just add a new api endpoint for SUARA News, i'd already tested it too.
Unfortunately, suara api only contains 2 type.
I'd already edited the documentation too.
Have a good day