Main changes to SauceOptions and SauceSession #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added overloaded methods for ISauceRemoteDriver to include DataCenter and an int to pass in seconds for timeout. Implemented the overloaded methods in the SauceDriver class
Browser.cs: Added latest browsers DataCenter.cs: Updated URL for UsWest EdgeVersion.cs: Added latest versions IncorrectSafariVersionException.cs: Added method to display invalid version JsonUtils.cs: Added class to centralize serialization settings Platforms.cs: Added latest versions SauceOptions.cs: Updated Safari method to reflect latest platforms TestVisibility.cs: Added latest values Timeout.cs: removed JsonProperties as it handled by serializer SafariTests.cs: Updated test methods to test latest versions SauceOptionsTests.cs: Updated timeout key to reflect camel case naming convention
This commit has changes that touched several files. DataCenter.cs: Updated EuCentral to return a DataCenter rather than an object. SauceOptions.cs: With methods now provide method chaining, and properly overloaded. Added Authentication. Removed IWebDriver properties. Removed driver specific configured options. SauceSession.cs: Added overloaded constructors. Simplified the Start method. Removed authentication. Tests classes: Updated to reflect changes made to DataCenter, SauceOptions and SauceSession classes
Updated per Codacy
|
Complexity increasing per file
==============================
- dotnet/Simple.Sauce/IncorrectSafariVersionException.cs 1
- dotnet/Simple.Sauce/JsonUtils.cs 1
- dotnet/Simple.Sauce/SauceDriver.cs 1
- dotnet/Simple.Sauce/SauceOptions.cs 2
See the complete overview on Codacy |
|
@MattKeenum same problem here. It's better to open a new branch with a single feature for every PR. Take a look at some of these PRs as an example: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes were to SauceOptions and SauceSession. However, these changes resulted in touching several files. I tried to keep the changes minimal to make it easier to review, but these changes were prolific throughout several files.