Add implementation of CSI-Driver for Windows #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging the PR so that the review can be done in the |
saurabhc123
added a commit
that referenced
this pull request
Jun 18, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 3, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 3, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 12, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 12, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 12, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 12, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 12, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 15, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 15, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Jul 16, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
saurabhc123
added a commit
that referenced
this pull request
Sep 14, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Sep 17, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
jiuchoe4
added a commit
that referenced
this pull request
Sep 17, 2024
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the Windows logic for the CSI-Driver.
Implementation details
Implementation from aws-ebs-csi-driver was added. Also, pulled the socket file path from
watcher.gointoconfigand added Windows file path.Testing
UTs used for Linux was repurposed for Windows and are all passing.
Further,
csi_client_windows_integration_test.gowas ran with the CSI Driver, Proxy, and new EBS volume on the instance, and was able to successfully stage and unstage the volume to the mount directory.New tests cover the changes:
yesDescription for the changelog
Add EBS Task-attach support for Windows
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.