Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump checkout versions and use lint action #4

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

robinmuhia
Copy link
Contributor

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@robinmuhia robinmuhia force-pushed the refactor-CI branch 2 times, most recently from c099993 to f48c6a9 Compare June 21, 2024 06:55
@KathurimaKimathi KathurimaKimathi merged commit 0dd658f into main Jun 21, 2024
2 checks passed
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9609578913

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.667%

Totals Coverage Status
Change from base Build 9609387977: 0.0%
Covered Lines: 46
Relevant Lines: 60

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9609668749

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.667%

Totals Coverage Status
Change from base Build 9609387977: 0.0%
Covered Lines: 46
Relevant Lines: 60

💛 - Coveralls

@robinmuhia robinmuhia deleted the refactor-CI branch June 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants