Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check devel-updates from AUR with last commit #17

Merged
merged 11 commits into from
Dec 26, 2023

Conversation

jlaunay
Copy link

@jlaunay jlaunay commented Dec 24, 2023

In order to keep waybar-updates AUR Helper-agnostic I'm now checking if devel packages need an update using the latest commit on the git repository.
This version works for me at the moment, I'm still testing it.
Depending on the number of "devel" packages installed, the first run may take more or less time, but inside "check_updates offline", you only check the packages that have been previously flagged with changes upstream.

@jlaunay
Copy link
Author

jlaunay commented Dec 26, 2023

I think this PR is ready to be reviewed / merged !

Development packages have a suffix denoting their Version Control System.
Because these packages only download the latest available source when you execute makepkg, their pkgver() in the AUR does not reflect upstream changes.

AUR Helpers (like paru, yay etc.) maintain a database during installation/update to keep track of the last commit, and thus detect when an update is required after a new commit.

Advantage: speed because a database is used.
Disadvantage: if you install a package using an AUR Helper, others won't be able to detect that an update is needed.

You can enable development package checking (-git) using waybar-updates -d (or --devel, disabled by default).
The first run may take some time (depending on how many development packages you have) because we need to retrieve the git repository url then use git ls-remote to find the latest commit.

Once done, since the necessary informations are known, we just need to check the last commit.

@savely-krasovsky
Copy link
Owner

@jlaunay could you run shellcheck on it and fix any issues it will highlight? (JetBrains IDEs support it mostly out of the box). Also I am confused by "from Devel" terminology. Devel is not a source like pacman or AUR repos, it's just a kind of AUR-packages. So maybe we will use something like "1 devel-update available from AUR"?

@savely-krasovsky
Copy link
Owner

I have added ShellCheck GitHub action, but seems like there is no way to launch this check on already created PR...

@jlaunay
Copy link
Author

jlaunay commented Dec 26, 2023

@jlaunay could you run shellcheck on it and fix any issues it will highlight? (JetBrains IDEs support it mostly out of the box). Also I am confused by "from Devel" terminology. Devel is not a source like pacman or AUR repos, it's just a kind of AUR-packages. So maybe we will use something like "1 devel-update available from AUR"?

I run this against shellcheck and change for "devel-update available from AUR".
French translation is OK, you should check for "ru" and "tr_TR"

@jlaunay jlaunay changed the title check devel with last commit check devel-updates from AUR with last commit Dec 26, 2023
@savely-krasovsky
Copy link
Owner

savely-krasovsky commented Dec 26, 2023

@ouztheone do you have time to check Turkey translation?

po/tr_TR.po Outdated Show resolved Hide resolved
po/tr_TR.po Outdated Show resolved Hide resolved
@ouzbirki
Copy link
Contributor

@ouztheone do you have time to check Turkey translation?

Hey, thanks for the heads up. I added my suggestions. :)

savely-krasovsky and others added 2 commits December 26, 2023 21:50
Co-authored-by: ouztheone <oguzzakin@gmail.com>
Co-authored-by: ouztheone <oguzzakin@gmail.com>
@savely-krasovsky savely-krasovsky merged commit aa5b017 into savely-krasovsky:master Dec 26, 2023
2 checks passed
@jlaunay jlaunay deleted the develcheck branch December 26, 2023 20:56
@savely-krasovsky
Copy link
Owner

@jlaunay I will release update tomorrow, out of desk now!

@jlaunay
Copy link
Author

jlaunay commented Dec 26, 2023

@jlaunay I will release update tomorrow, out of desk now!

Thanks a lot, in the meantime, I published a waybar-updates-git package on AUR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants