Skip to content

Commit

Permalink
Limit the maximum Maven Plug-in API version to be at most 3.6.4 (#1634)
Browse files Browse the repository at this point in the history
### What's done:

 - Versions 3.7.0+ are incompatible.
 - Fixes #1632.
  • Loading branch information
0x6675636b796f75676974687562 authored Mar 17, 2023
1 parent 08c1eda commit d209360
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@
<detekt.version>1.22.0</detekt.version>
<dokka.version>1.8.10</dokka.version>
<jacoco.version>0.8.8</jacoco.version>
<maven-plugin-tools.version>3.8.1</maven-plugin-tools.version>
<!-- Don't upgrade before checking compatibility with `kotlin-maven-plugin-tools`.
See also `renovate.json`.
See https://github.com/saveourtool/diktat/issues/1632 for details. -->
<maven-plugin-tools.version>3.6.4</maven-plugin-tools.version>
<jbool.version>1.24</jbool.version>
<!-- downgraded to be compliance with ktlint -->
<mu-logging.version>2.1.23</mu-logging.version>
Expand Down
14 changes: 14 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,20 @@
],
"allowedVersions": "<= 0.47.0"
},
{
"managers": ["maven"],
"matchPackageNames": [
"org.apache.maven.plugins:maven-plugin-plugin"
],
"allowedVersions": "< 3.7.0"
},
{
"managers": ["maven"],
"matchPackageNames": [
"org.apache.maven.plugin-tools:maven-plugin-annotations"
],
"allowedVersions": "< 3.7.0"
},
{
"managers": ["gradle"],
"matchPackagePatterns": [
Expand Down

0 comments on commit d209360

Please sign in to comment.