Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using lastIndex instead of length - 1 for strings #1140

Closed
orchestr7 opened this issue Dec 3, 2021 · 1 comment · Fixed by #1221
Closed

Suggest using lastIndex instead of length - 1 for strings #1140

orchestr7 opened this issue Dec 3, 2021 · 1 comment · Fixed by #1221
Assignees
@Arrgentum
Labels
enhancement New feature or request
Milestone
1.0.4

Comments

@orchestr7
Copy link
Member

No description provided.

@orchestr7 orchestr7 added the enhancement New feature or request label Dec 3, 2021
@orchestr7 orchestr7 added this to the 1.0.4 milestone Jan 26, 2022
@orchestr7 orchestr7 self-assigned this Jan 26, 2022
@orchestr7 orchestr7 assigned Arrgentum and unassigned orchestr7 Feb 22, 2022
@Arrgentum
Copy link
Member

What do you mean by the word strings?
Check in the whole project or only in chapter 3?

Arrgentum pushed a commit that referenced this issue Mar 1, 2022
Change .length - 1 to .lastIndex
cddcb5e 
What's done:
 - Added new rule to replace .length - 1 to .lastIndex
 - Added warn tests
 - Added fix tests

 (#1140)
Arrgentum pushed a commit that referenced this issue Mar 1, 2022
Change .length - 1 to .lastIndex
4fa104b 
What's done:
 - Added new rule to replace .length - 1 to .lastIndex
 - Added warn tests
 - Added fix tests

 (#1140)
Arrgentum pushed a commit that referenced this issue Mar 2, 2022
Change property length with operation - 1 to property lastIndex
8bbe9ff 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum pushed a commit that referenced this issue Mar 2, 2022
Change property length with operation - 1 to property lastIndex
643b693 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
@Arrgentum Arrgentum mentioned this issue Mar 2, 2022
Merged
3 tasks
Arrgentum pushed a commit that referenced this issue Mar 2, 2022
Change property length with operation - 1 to property lastIndex
1893720 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum pushed a commit that referenced this issue Mar 2, 2022
Change property length with operation - 1 to property lastIndex
c46c481 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum pushed a commit that referenced this issue Mar 3, 2022
Change property length with operation - 1 to property lastIndex
3f4afe6 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum pushed a commit that referenced this issue Mar 3, 2022
Change property length with operation - 1 to property lastIndex
efe4a0d 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum pushed a commit that referenced this issue Mar 4, 2022
Change property length with operation - 1 to property lastIndex
7ab9210 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum pushed a commit that referenced this issue Mar 4, 2022
Change property length with operation - 1 to property lastIndex
8c4a93e 
### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)
Arrgentum added a commit that referenced this issue Mar 11, 2022
@Arrgentum
Suggest using lastIndex instead of length - 1 for strings (#1221)
aa3c22b 
* Change property length with operation - 1 to property lastIndex

### What's done:
- Added new rule to replace ".length - 1" to ".lastIndex"
- Added warn tests
- Added fix tests
- Updated Readme (rule 6.2.4)

(#1140)

Co-authored-by: Alexey Votintsev <alexeyvotintsev.yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arrgentum Arrgentum

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

Suggest using lastIndex instead of length - 1 for strings saveourtool/diktat
2 participants
@orchestr7 @Arrgentum