Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface vs Data class bug#1003 #1014

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Jul 30, 2021

What's done:

### What's done:
Fixed bug
Added test
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1014 (690fdfd) into master (da86140) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1014      +/-   ##
============================================
- Coverage     83.81%   83.80%   -0.01%     
+ Complexity     2427     2425       -2     
============================================
  Files           102      102              
  Lines          6103     6100       -3     
  Branches       1806     1806              
============================================
- Hits           5115     5112       -3     
  Misses          268      268              
  Partials        720      720              
Flag Coverage Δ
unittests 83.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ruleset/rules/chapter6/classes/DataClassesRule.kt 75.00% <100.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da86140...690fdfd. Read the comment docs.

@kentr0w kentr0w marked this pull request as ready for review July 30, 2021 12:24
@kentr0w kentr0w requested review from petertrr and orchestr7 July 30, 2021 12:24
### What's done:
Fixed after review
@kentr0w kentr0w merged commit e67c8a6 into master Jul 30, 2021
@kentr0w kentr0w deleted the bugfix/interface_vs_data_class branch July 30, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interfaces are violating the USE_DATA_CLASS rule
2 participants