Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name bug#1015 #1016

Merged
merged 7 commits into from
Aug 2, 2021
Merged

Package name bug#1015 #1016

merged 7 commits into from
Aug 2, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Jul 30, 2021

kentr0w added 2 commits July 30, 2021 16:39
### What's done:
Fixed bug
Added test
### What's done:
Fixed to build
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1016 (13baf27) into master (1098554) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1016   +/-   ##
=========================================
  Coverage     83.81%   83.82%           
  Complexity     2419     2419           
=========================================
  Files           102      102           
  Lines          6104     6107    +3     
  Branches       1809     1809           
=========================================
+ Hits           5116     5119    +3     
  Misses          268      268           
  Partials        720      720           
Flag Coverage Δ
unittests 83.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kotlin/org/cqfn/diktat/ruleset/utils/FileUtils.kt 100.00% <ø> (ø)
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 91.34% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1098554...13baf27. Read the comment docs.

kentr0w added 2 commits July 30, 2021 17:24
### What's done:
Updated kdoc
### What's done:
Simplified code
@kentr0w kentr0w marked this pull request as ready for review July 30, 2021 14:45
@kentr0w kentr0w requested a review from petertrr July 30, 2021 14:49
kentr0w added 3 commits August 2, 2021 12:07
### What's done:
Fixed after review
### What's done:
Fixed according to our code style
@kentr0w kentr0w merged commit 841ef74 into master Aug 2, 2021
@kentr0w kentr0w deleted the bugfix/package-bug#1015 branch August 2, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PACKAGE_NAME_INCORRECT_PATH: incorrectly calculates PATH to the directory if the directory is named with dots
2 participants